feat(plugin-typescript): support multiple tsconfigs#1229
Conversation
|
View your CI Pipeline Execution ↗ for commit 2742149
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/axe-plugin
@code-pushup/nx-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit c9b8509 with previous commit d3230f1. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 2 groups improved, 👎 2 groups regressed, 👍 10 audits improved, 👎 3 audits regressed, 26 audits changed without impacting score🗃️ Groups
30 other groups are unchanged. 🛡️ Audits
640 other audits are unchanged. |
b9c748a to
8f419a0
Compare
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit c9b8509 with previous commit d3230f1. 💼 Project
|
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Documentation | 🔴 45 | 🟡 61 | |
| Code coverage | 🟢 95 | 🟢 95 |
4 other categories are unchanged.
👍 1 group improved, 👎 1 group regressed, 👍 8 audits improved, 👎 1 audit regressed
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| JSDocs coverage | Documentation coverage | 🔴 45 | 🟡 61 | |
| Code coverage | Code coverage metrics | 🟢 95 | 🟢 95 |
13 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| JSDocs coverage | Classes coverage | 🟨 3 undocumented classes | 🟨 2 undocumented classes | |
| JSDocs coverage | Properties coverage | 🟥 27 undocumented properties | 🟥 39 undocumented properties | |
| JSDocs coverage | Methods coverage | 🟨 13 undocumented methods | 🟨 10 undocumented methods | |
| JSDocs coverage | Variables coverage | 🟥 49 undocumented variables | 🟥 50 undocumented variables | |
| JSDocs coverage | Types coverage | 🟥 66 undocumented types | 🟨 55 undocumented types | |
| JSDocs coverage | Functions coverage | 🟥 239 undocumented functions | 🟥 243 undocumented functions | |
| Code coverage | Function coverage | 🟩 96.2 % | 🟩 95.8 % | |
| Code coverage | Line coverage | 🟩 97.8 % | 🟩 97.8 % | |
| Code coverage | Branch coverage | 🟩 91.8 % | 🟩 91.9 % |
435 other audits are unchanged.
💼 Project plugin-typescript
🤨 Code PushUp report has both improvements and regressions.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟡 87 | 🟡 89 | |
| Documentation | 🟡 73 | 🟡 73 |
4 other categories are unchanged.
👍 1 group improved, 👎 1 group regressed, 👍 3 audits improved, 👎 2 audits regressed, 1 audit changed without impacting score
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟡 87 | 🟡 89 | |
| JSDocs coverage | Documentation coverage | 🟡 73 | 🟡 73 |
13 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Function coverage | 🟨 88.9 % | 🟩 92.3 % | |
| JSDocs coverage | Functions coverage | 🟨 9 undocumented functions | 🟥 13 undocumented functions | |
| Code coverage | Branch coverage | 🟨 80.2 % | 🟨 81.4 % | |
| JSDocs coverage | Variables coverage | 🟥 11 undocumented variables | 🟥 12 undocumented variables | |
| Code coverage | Line coverage | 🟩 95.5 % | 🟩 95.5 % | |
| JSDocs coverage | Types coverage | 🟥 8 undocumented types | 🟥 11 undocumented types |
438 other audits are unchanged.
💼 Project plugin-coverage
🤨 Code PushUp report has both improvements and regressions.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟢 90 | 🟢 92 | |
| Documentation | 🟡 69 | 🟡 69 |
4 other categories are unchanged.
👍 1 group improved, 👎 1 group regressed, 👍 2 audits improved, 👎 1 audit regressed
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟢 90 | 🟢 92 | |
| JSDocs coverage | Documentation coverage | 🟡 69 | 🟡 69 |
13 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Function coverage | 🟩 90.6 % | 🟩 93.5 % | |
| JSDocs coverage | Functions coverage | 🟥 22 undocumented functions | 🟥 22 undocumented functions | |
| Code coverage | Line coverage | 🟨 88 % | 🟨 89.1 % |
441 other audits are unchanged.
💼 Project plugin-eslint
🤨 Code PushUp report has both improvements and regressions.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Documentation | 🟡 67 | 🟡 67 | |
| Code coverage | 🟢 94 | 🟢 94 |
4 other categories are unchanged.
👍 1 group improved, 👎 1 group regressed, 👍 2 audits improved, 👎 2 audits regressed
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| JSDocs coverage | Documentation coverage | 🟡 67 | 🟡 67 | |
| Code coverage | Code coverage metrics | 🟢 94 | 🟢 94 |
13 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| JSDocs coverage | Functions coverage | 🟥 48 undocumented functions | 🟥 48 undocumented functions | |
| Code coverage | Line coverage | 🟩 95 % | 🟩 95.3 % | |
| Code coverage | Branch coverage | 🟨 86.5 % | 🟨 86.8 % | |
| Code coverage | Function coverage | 🟩 98.2 % | 🟩 98.2 % |
440 other audits are unchanged.
💼 Project plugin-axe
🤨 Code PushUp report has both improvements and regressions.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Documentation | 🟡 70 | 🟡 70 | |
| Code coverage | 🟢 94 | 🟢 94 |
4 other categories are unchanged.
👍 1 group improved, 👎 1 group regressed, 👍 2 audits improved, 👎 1 audit regressed
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| JSDocs coverage | Documentation coverage | 🟡 70 | 🟡 70 | |
| Code coverage | Code coverage metrics | 🟢 94 | 🟢 94 |
13 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| JSDocs coverage | Functions coverage | 🟨 12 undocumented functions | 🟨 12 undocumented functions | |
| Code coverage | Line coverage | 🟨 72.7 % | 🟨 73 % | |
| Code coverage | Branch coverage | 🟨 89.9 % | 🟩 90 % |
440 other audits are unchanged.
💼 Project create-cli
😟 Code PushUp report has regressed.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟢 96 | 🟢 96 |
5 other categories are unchanged.
👎 1 group regressed, 👎 1 audit regressed
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟢 96 | 🟢 96 |
14 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Branch coverage | 🟨 88.2 % | 🟨 87.5 % |
443 other audits are unchanged.
💼 Project ci
😟 Code PushUp report has regressed.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟢 92 | 🟢 92 |
5 other categories are unchanged.
👎 1 group regressed, 👎 1 audit regressed, 1 audit changed without impacting score
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟢 92 | 🟢 92 |
14 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Branch coverage | 🟨 83.6 % | 🟨 83.6 % | |
| Code coverage | Line coverage | 🟩 94.8 % | 🟩 94.8 % |
443 other audits are unchanged.
💼 Project models
🤨 Code PushUp report has both improvements and regressions.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Documentation | 🟡 66 | 🟡 66 | |
| Code coverage | 🟢 94 | 🟢 94 |
2 other categories are unchanged.
👍 1 group improved, 👎 1 group regressed, 👍 1 audit improved, 👎 1 audit regressed, 1 audit changed without impacting score
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| JSDocs coverage | Documentation coverage | 🟡 66 | 🟡 66 | |
| Code coverage | Code coverage metrics | 🟢 94 | 🟢 94 |
10 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| JSDocs coverage | Variables coverage | 🟥 72 undocumented variables | 🟥 76 undocumented variables | |
| Code coverage | Line coverage | 🟩 99.4 % | 🟩 99.4 % | |
| JSDocs coverage | Types coverage | 🟥 53 undocumented types | 🟥 57 undocumented types |
434 other audits are unchanged.
💼 Project core
🥳 Code PushUp report has improved.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟢 90 | 🟢 90 |
5 other categories are unchanged.
👍 1 group improved, 👍 1 audit improved
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟢 90 | 🟢 90 |
14 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Line coverage | 🟩 94.8 % | 🟩 94.8 % |
443 other audits are unchanged.
5 other projects are unchanged.
8f419a0 to
6122c13
Compare
BioPhoton
left a comment
There was a problem hiding this comment.
Nice extend of our typescript plugin! Left a comment.
BioPhoton
left a comment
There was a problem hiding this comment.
With the last refinement it looks perfect!
matejchalk
left a comment
There was a problem hiding this comment.
Great work, thanks 👏
Closes #1217
tsconfigFromAllNxProjectshelper to auto-discover tsconfigs in Nx workspaces